Skip to content

feat(event cache): take the cross-process lock once per sync update #5555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

feat(event cache): take the cross-process lock once per sync update #5555

wants to merge 10 commits into from

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Aug 19, 2025

An attempt at taming #5554.

bnjbvr added 10 commits August 19, 2025 16:38
@bnjbvr
chore(logs): simplify logs around taking a read/write sqlite connection
c20b6b3
@bnjbvr
feat(event cache): use the event cache store lock as little as we must
085f872
@bnjbvr
fixup! feat(event cache): use the event cache store lock as little as…
56c64fb 
… we must
@bnjbvr
fixup! feat(event cache): use the event cache store lock as little as…
9c605e6 
… we must
@bnjbvr
fixup! feat(event cache): use the event cache store lock as little as…
5fe1c3e 
… we must
@bnjbvr
fixup! feat(event cache): use the event cache store lock as little as…
c9d76c2 
… we must
@bnjbvr
refactor(event cache): get rid of RoomEventCacheState::store \o/
5bf1cbd
@bnjbvr
refactor(event cache): pass the full store object even less
5eee20f
@bnjbvr
feat(event cache): process room updates concurrently
0a50883 
This should improve latency of event cache updates in general,
especially for massive initial sync responses (which may include many
many rooms).
@bnjbvr
Revert "feat(event cache): process room updates concurrently"
7113973 
This reverts commit 0a50883.
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 19, 2025

CodSpeed Performance Report

Merging #5555 will not alter performance

Comparing bnjbvr/event-cache-store (7113973) with main (d1a8392)

Summary

✅ 31 untouched benchmarks

@codecov Codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 80.86957% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.61%. Comparing base (d1a8392) to head (7113973).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/event_cache/room/mod.rs 81.14% 7 Missing and 26 partials ⚠️
crates/matrix-sdk/src/event_cache/mod.rs 85.71% 1 Missing and 4 partials ⚠️
...rates/matrix-sdk-base/src/event_cache/store/mod.rs 60.00% 3 Missing and 1 partial ⚠️
crates/matrix-sdk/src/event_cache/pagination.rs 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #5555    +/-   ##
========================================
  Coverage   88.61%   88.61%            
========================================
  Files         340      340            
  Lines       94977    95077   +100     
  Branches    94977    95077   +100     
========================================
+ Hits        84166    84256    +90     
- Misses       6634     6641     +7     
- Partials     4177     4180     +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bnjbvr